diff options
| author | Andrew Dolgov <fox@fakecake.org> | 2026-10-14 21:40:28 +0300 |
|---|---|---|
| committer | Andrew Dolgov <fox@fakecake.org> | 2026-10-14 21:40:28 +0300 |
| commit | 48d7b08a87adec0ce1c114bd5c70c0f6e108a954 (patch) | |
| tree | 906546542b5df2689ee6a0c16b889df82f947580 | |
| parent | a5652f406c6a1fdadb40f65d56e6141800103f61 (diff) | |
| download | the-epube-48d7b08a87adec0ce1c114bd5c70c0f6e108a954.tar.gz the-epube-48d7b08a87adec0ce1c114bd5c70c0f6e108a954.tar.xz | |
prevent storing pagination for nonexistant books
| -rw-r--r-- | classes/Handler/PaginationHandler.php | 18 | ||||
| -rw-r--r-- | tests_integration/PaginationHandlerTest.php | 38 |
2 files changed, 51 insertions, 5 deletions
diff --git a/classes/Handler/PaginationHandler.php b/classes/Handler/PaginationHandler.php index 03388c9..de22037 100644 --- a/classes/Handler/PaginationHandler.php +++ b/classes/Handler/PaginationHandler.php @@ -3,7 +3,9 @@ namespace Handler; use AuthRequired; +use Config; use ORM; +use PDO; use Request; use RequestHandlerInterface; use Response; @@ -16,6 +18,20 @@ class PaginationHandler implements RequestHandlerInterface, AuthRequired * while still bounding unbounded storage growth. */ private const MAX_PAYLOAD_SIZE = 16 * 1024 * 1024; + + /** + * Verify the id refers to an actual library entry in the Calibre DB. + * The frontend keys pagination by the EPUB 'data' row id, but accept + * a 'books' row id as well for robustness/backwards compatibility. + */ + private function bookExists(int $bookid): bool + { + $caldb = new PDO('sqlite:' . Config::get(Config::CALIBRE_DB)); + $sth = $caldb->prepare("SELECT 1 FROM data WHERE id = ? UNION SELECT 1 FROM books WHERE id = ? LIMIT 1"); + $sth->execute([$bookid, $bookid]); + return (bool)$sth->fetch(); + } + private function handleGet(int $bookid): Response { if ($bookid) { @@ -51,7 +67,7 @@ class PaginationHandler implements RequestHandlerInterface, AuthRequired $payload = null; } - if ($bookid && $payload) { + if ($bookid && $payload && $this->bookExists($bookid)) { $pag = ORM::for_table('epube_pagination') ->where('bookid', $bookid) ->find_one(); diff --git a/tests_integration/PaginationHandlerTest.php b/tests_integration/PaginationHandlerTest.php index 4674e1e..503178c 100644 --- a/tests_integration/PaginationHandlerTest.php +++ b/tests_integration/PaginationHandlerTest.php @@ -69,7 +69,8 @@ final class PaginationHandlerTest extends ApiTestCase ]); $this->assertEquals(200, $status); - $bookid = 99998; + // Real Calibre 'data' row id from the fixture metadata.db + $bookid = 5; $this->deletePagination($bookid); $payload = '{"page":12,"cfi":"epubcfi(/6/14[]/4:123)"}'; @@ -100,7 +101,8 @@ final class PaginationHandlerTest extends ApiTestCase ]); $this->assertEquals(200, $status); - $bookid = 99997; + // Real Calibre 'data' row id from the fixture metadata.db + $bookid = 6; $this->deletePagination($bookid); // Create initial record @@ -155,7 +157,7 @@ final class PaginationHandlerTest extends ApiTestCase ]); $this->assertEquals(200, $status); - $bookid = 99996; + $bookid = 8; $this->deletePagination($bookid); [$status, $body] = $this->post($this->apiUrl, [ @@ -172,6 +174,33 @@ final class PaginationHandlerTest extends ApiTestCase $this->assertNull($record); } + public function test_storepagination_rejects_nonexistent_book(): void + { + // Login + [$status, $body] = $this->post($this->apiUrl, [ + 'op' => 'perform-login', + 'user' => 'test', + 'password' => 'test', + ]); + $this->assertEquals(200, $status); + + // Valid payload, but no such row in Calibre books/data tables + $bookid = 99990; + $this->deletePagination($bookid); + + [$status, $body] = $this->post($this->apiUrl, [ + 'op' => 'storepagination', + 'id' => $bookid, + 'payload' => '{"page":1}', + ]); + + $this->assertEquals(200, $status); + + // Verify no record was created for a book that does not exist + $record = $this->getPagination($bookid); + $this->assertNull($record); + } + // ── getpagination ──────────────────────────────────────────────────────── public function test_getpagination_returns_stored_data(): void @@ -184,7 +213,8 @@ final class PaginationHandlerTest extends ApiTestCase ]); $this->assertEquals(200, $status); - $bookid = 99995; + // Real Calibre 'data' row id from the fixture metadata.db + $bookid = 9; $this->deletePagination($bookid); $payload = '{"page":42,"cfi":"epubcfi(/6/30[]/4:789)"}'; |
