diff options
| author | fox <fox@fakecake.org> | 2026-10-11 08:46:48 +0300 |
|---|---|---|
| committer | GitLab <noreply@fakecake.org> | 2026-10-11 08:46:48 +0300 |
| commit | 680836cd0983d13eebd4209416e4747c5ba17b58 (patch) | |
| tree | 03436a3901bf5b2d9d3ea88f6c3713463039c2b1 /include/sessions.php | |
| parent | 6f771f8b9468f012ba74f2e7d139efe7afbaf321 (diff) | |
| parent | 9b7d8300575ef5bf3c2daeecf97ec4055f944334 (diff) | |
| download | the-epube-680836cd0983d13eebd4209416e4747c5ba17b58.tar.gz the-epube-680836cd0983d13eebd4209416e4747c5ba17b58.tar.xz | |
Merge branch 'dev' into 'master'
set missing cookie parameters (samesite & httponly) and fix possible XSS in... See merge request git/the-epube!75
Diffstat (limited to 'include/sessions.php')
| -rw-r--r-- | include/sessions.php | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/include/sessions.php b/include/sessions.php index 1fa1e2f..b433fb9 100644 --- a/include/sessions.php +++ b/include/sessions.php @@ -6,15 +6,21 @@ $session_name = Config::get(Config::SESSION_NAME); $session_expire = Config::get(Config::SESSION_LIFETIME); - if (Config::is_server_https()) - ini_set("session.cookie_secure", "true"); - ini_set("session.name", "epube_sid"); ini_set("session.use_only_cookies", "true"); ini_set("session.gc_maxlifetime", $session_expire); ini_set("session.cookie_lifetime", "0"); - session_set_cookie_params($session_expire); + // Array signature sets all attributes at once; the legacy scalar form + // silently reset secure/httponly to their defaults. + session_set_cookie_params([ + 'lifetime' => $session_expire, + 'path' => '/', + 'domain' => '', + 'secure' => Config::is_server_https(), + 'httponly' => true, + 'samesite' => 'Lax', + ]); session_save_path(dirname(__DIR__) . "/sessions"); |
