diff options
| author | Andrew Dolgov <fox@fakecake.org> | 2026-06-06 13:57:35 +0300 |
|---|---|---|
| committer | Andrew Dolgov <fox@fakecake.org> | 2026-06-06 13:57:35 +0300 |
| commit | 53439265b63fcbd18c68f4401b0ae35f7f8d3993 (patch) | |
| tree | 5a143b7abc7ce688910dfbc9f633d73f9b4fcf71 /org.fox.ttrss | |
| parent | 950ec50ff4cb118109e55138afa63434e509c1f3 (diff) | |
| download | tt-rss-android-53439265b63fcbd18c68f4401b0ae35f7f8d3993.tar.gz tt-rss-android-53439265b63fcbd18c68f4401b0ae35f7f8d3993.tar.xz | |
replace printStackTrace() instances with Log.e()
Diffstat (limited to 'org.fox.ttrss')
19 files changed, 58 insertions, 50 deletions
diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiCommon.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiCommon.java index 89152121..cafe28ce 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiCommon.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiCommon.java @@ -468,7 +468,7 @@ public class ApiCommon { // enable mtls in okhttp3 builder builder.sslSocketFactory(sslContext.getSocketFactory()); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "configuring mTLS", e); caller.setLastErrorMessage(e.getMessage()); caller.setLastError(ApiError.API_UNKNOWN); @@ -553,7 +553,7 @@ public class ApiCommon { } catch (javax.net.ssl.SSLPeerUnverifiedException e) { caller.setLastError(ApiError.SSL_REJECTED); caller.setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "SSL certificate rejected", e); } catch (IOException e) { caller.setLastError(ApiError.IO_ERROR); caller.setLastErrorMessage(e.getMessage()); @@ -564,15 +564,15 @@ public class ApiCommon { } } - e.printStackTrace(); + Log.e(TAG, "IO error", e); } catch (com.google.gson.JsonSyntaxException e) { caller.setLastError(ApiError.PARSE_ERROR); caller.setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "JSON parse error", e); } catch (Exception e) { caller.setLastError(ApiError.OTHER_ERROR); caller.setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "API request failed", e); } return null; @@ -656,7 +656,7 @@ public class ApiCommon { System.getProperty("http.agent")); } catch (PackageManager.NameNotFoundException e) { - e.printStackTrace(); + Log.e(TAG, "getting package info", e); return String.format(Locale.ENGLISH, "Tiny Tiny RSS (Android) Unknown %1$s", diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiV2Client.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiV2Client.java index be4e643a..863f56a5 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiV2Client.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/ApiV2Client.java @@ -86,7 +86,7 @@ public class ApiV2Client { sslContext.init(keyManagers, trustManagers, null); builder.sslSocketFactory(sslContext.getSocketFactory()); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "mTLS setup failed", e); } } } @@ -261,7 +261,7 @@ public class ApiV2Client { } catch (javax.net.ssl.SSLPeerUnverifiedException e) { caller.setLastError(ApiError.SSL_REJECTED); caller.setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "API response error", e); return null; } catch (IOException e) { caller.setLastError(ApiError.IO_ERROR); @@ -271,12 +271,12 @@ public class ApiV2Client { caller.setLastError(ApiError.SSL_HOSTNAME_REJECTED); } - e.printStackTrace(); + Log.e(TAG, "SSL peer unverified", e); return null; } catch (Exception e) { caller.setLastError(ApiError.OTHER_ERROR); caller.setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "IO error during request", e); return null; } } @@ -366,7 +366,7 @@ public class ApiV2Client { System.getProperty("http.agent")); } catch (PackageManager.NameNotFoundException e) { - e.printStackTrace(); + Log.e(TAG, "unexpected error", e); return String.format(Locale.ENGLISH, "Tiny Tiny RSS (Android) Unknown %1$s", System.getProperty("http.agent")); diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleFragment.java index 8bed4c4a..73f2184b 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleFragment.java @@ -133,7 +133,7 @@ public class ArticleFragment extends androidx.fragment.app.Fragment { try { m_activity.openUri(Uri.parse(m_article.link)); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "opening article link", e); m_activity.toast(R.string.error_other_error); } }); @@ -157,7 +157,7 @@ public class ArticleFragment extends androidx.fragment.app.Fragment { m_activity.openUri(Uri.parse(url)); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "opening comments/links", e); m_activity.toast(R.string.error_other_error); } }); @@ -255,7 +255,7 @@ public class ArticleFragment extends androidx.fragment.app.Fragment { return true; } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "opening URL from context menu", e); } return false; @@ -368,7 +368,7 @@ public class ArticleFragment extends androidx.fragment.app.Fragment { } catch (MalformedURLException e) { // } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "processing image URL", e); } } } @@ -398,7 +398,7 @@ public class ArticleFragment extends androidx.fragment.app.Fragment { } } catch (RuntimeException e) { - e.printStackTrace(); + Log.e(TAG, "rendering article content", e); } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleModel.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleModel.java index 7e1189cd..6d557635 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleModel.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleModel.java @@ -79,7 +79,7 @@ public class ArticleModel extends AndroidViewModel implements ApiCommon.ApiCalle m_clientCertChain.postValue(KeyChain.getCertificateChain(application, clientCertAlias)); m_clientCertKey.postValue(KeyChain.getPrivateKey(application, clientCertAlias)); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "loading client certificate", e); } }); } @@ -332,7 +332,7 @@ public class ArticleModel extends AndroidViewModel implements ApiCommon.ApiCalle setLastError(ApiCommon.ApiError.OTHER_ERROR); setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "fetching client certificate", e); } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticlePager.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticlePager.java index c2eeba49..b8bafe8c 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticlePager.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticlePager.java @@ -152,7 +152,7 @@ public class ArticlePager extends androidx.fragment.app.Fragment { Application.getArticlesModel().setActive(targetArticle); } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "setting active article", e); } } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/CommonActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/CommonActivity.java index ef8660ad..d36a7d91 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/CommonActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/CommonActivity.java @@ -385,7 +385,7 @@ public class CommonActivity extends AppCompatActivity implements SharedPreferenc startActivity(Intent.createChooser(sendIntent, null)); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "sharing content", e); toast(e.getMessage()); } @@ -418,7 +418,7 @@ public class CommonActivity extends AppCompatActivity implements SharedPreferenc try { intent.launchUrl(this, uri); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "launching URL", e); toast(e.getMessage()); } } @@ -433,7 +433,7 @@ public class CommonActivity extends AppCompatActivity implements SharedPreferenc try { uri = Uri.parse("https:" + uri); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "fixing URI scheme", e); } } @@ -478,7 +478,7 @@ public class CommonActivity extends AppCompatActivity implements SharedPreferenc try { startActivity(intent); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "starting activity", e); toast(e.getMessage()); } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/DetailActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/DetailActivity.java index 77a70d02..cbddec2c 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/DetailActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/DetailActivity.java @@ -279,7 +279,7 @@ public class DetailActivity extends OnlineActivity implements HeadlinesEventList super.onBackPressed(); } catch (IllegalStateException e) { // java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState - e.printStackTrace(); + Log.e(TAG, "back pressed", e); } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java index 6ec8ee01..c38ce800 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsFragment.java @@ -111,7 +111,7 @@ public class FeedsFragment extends Fragment implements OnSharedPreferenceChangeL } } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "feed context menu", e); } Log.d(TAG, "onContextItemSelected, unhandled id=" + item.getItemId()); diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsModel.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsModel.java index ff3510ad..d1c7c20f 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsModel.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/FeedsModel.java @@ -133,7 +133,7 @@ public class FeedsModel extends AndroidViewModel implements ApiCommon.ApiCaller setLastError(ApiCommon.ApiError.OTHER_ERROR); setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "fetching feeds", e); } m_isLoading.postValue(false); diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java index 7b97a60b..317a9bb6 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryActivity.java @@ -205,7 +205,7 @@ public class GalleryActivity extends CommonActivity { popup.show(); } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "selecting gallery item", e); } }); } @@ -221,7 +221,7 @@ public class GalleryActivity extends CommonActivity { return true; } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "gallery menu item selected", e); } return super.onContextItemSelected(item); @@ -236,7 +236,7 @@ public class GalleryActivity extends CommonActivity { try { openUri(Uri.parse(url)); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "opening image URL", e); toast(R.string.error_other_error); } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryModel.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryModel.java index 61fd139e..b97472c7 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryModel.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/GalleryModel.java @@ -60,7 +60,7 @@ public class GalleryModel extends AndroidViewModel { return "data".equalsIgnoreCase(uri.getScheme()); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "checking gallery scheme", e); } return false; @@ -156,7 +156,7 @@ public class GalleryModel extends AndroidViewModel { m_items.postValue(checkList); } } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "checking image for gallery", e); } } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java index 11325713..51e9d775 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/HeadlinesFragment.java @@ -186,7 +186,7 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { if (!onArticleMenuItemSelected(item, article, info.position)) return super.onContextItemSelected(item); } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "headlines context menu", e); } } @@ -352,7 +352,7 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { } } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "updating article", e); } } }); @@ -401,7 +401,7 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { m_readArticles.add(new Article(article)); } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "marking articles read", e); } } @@ -964,7 +964,7 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { } catch (NumberFormatException e) { m_activity.toast(R.string.score_invalid); - e.printStackTrace(); + Log.e(TAG, "setting article score", e); } }) .setNegativeButton(getString(R.string.cancel), @@ -1240,13 +1240,13 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { mp.setLooping(true); mp.start(); } catch (IllegalStateException e) { - e.printStackTrace(); + Log.e(TAG, "starting media playback", e); } }); m_mediaPlayer.prepareAsync(); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "preparing media player", e); } } @@ -1261,7 +1261,7 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { try { m_mediaPlayer.release(); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "releasing media player", e); } return false; } @@ -1372,7 +1372,7 @@ public class HeadlinesFragment extends androidx.fragment.app.Fragment { excerpt = excerpt.substring(0, CommonActivity.EXCERPT_MAX_LENGTH) + "…"; } } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "truncating excerpt", e); excerpt = ""; } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/MasterActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/MasterActivity.java index 505310b6..23090c52 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/MasterActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/MasterActivity.java @@ -359,7 +359,7 @@ public class MasterActivity extends OnlineActivity implements HeadlinesEventList setSortMode((String) sortNames[which]); } catch (IndexOutOfBoundsException e) { - e.printStackTrace(); + Log.e(TAG, "handling share intent", e); } dialog.cancel(); @@ -387,7 +387,7 @@ public class MasterActivity extends OnlineActivity implements HeadlinesEventList super.onBackPressed(); } catch (IllegalStateException e) { // java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState - e.printStackTrace(); + Log.e(TAG, "startup activity selection", e); } } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java index 45875ec6..a65a3dc1 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/OnlineActivity.java @@ -292,7 +292,7 @@ public class OnlineActivity extends CommonActivity { try { openUri(Uri.parse(getLastContentImageHitTestUrl())); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "opening content image", e); toast(R.string.error_other_error); } } @@ -846,7 +846,7 @@ public class OnlineActivity extends CommonActivity { } catch (NumberFormatException e) { toast(R.string.score_invalid); - e.printStackTrace(); + Log.e(TAG, "setting article score", e); } }) .setNegativeButton(getString(R.string.cancel), @@ -1247,7 +1247,7 @@ public class OnlineActivity extends CommonActivity { } } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "login request", e); } setSessionId(null); diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/PreferencesFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/PreferencesFragment.java index 6826c453..5f81afe7 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/PreferencesFragment.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/PreferencesFragment.java @@ -5,6 +5,7 @@ import android.content.SharedPreferences; import android.content.pm.PackageInfo; import android.content.pm.PackageManager; import android.os.Bundle; +import android.util.Log; import androidx.annotation.Nullable; import androidx.preference.PreferenceFragmentCompat; @@ -16,6 +17,7 @@ import java.text.SimpleDateFormat; import java.util.Date; public class PreferencesFragment extends PreferenceFragmentCompat { + private static final String TAG = "PreferencesFragment"; @Override public void onCreate(Bundle savedInstanceState) { @@ -66,7 +68,7 @@ public class PreferencesFragment extends PreferenceFragmentCompat { findPreference("build_timestamp").setSummary(getString(R.string.prefs_build_timestamp, buildTimestamp)); } catch (PackageManager.NameNotFoundException e) { - e.printStackTrace(); + Log.e(TAG, "getting package info", e); } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/RootCategoriesModel.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/RootCategoriesModel.java index 59790346..d1e3a04a 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/RootCategoriesModel.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/RootCategoriesModel.java @@ -73,7 +73,7 @@ public class RootCategoriesModel extends FeedsModel { setLastError(ApiCommon.ApiError.OTHER_ERROR); setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "loading root categories", e); } } @@ -144,7 +144,7 @@ public class RootCategoriesModel extends FeedsModel { setLastError(ApiCommon.ApiError.OTHER_ERROR); setLastErrorMessage(e.getMessage()); - e.printStackTrace(); + Log.e(TAG, "loading nested categories", e); } m_isLoading.postValue(false); diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/glide/OkHttpProgressGlideModule.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/glide/OkHttpProgressGlideModule.java index b50a4bee..e0ddd9c2 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/glide/OkHttpProgressGlideModule.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/glide/OkHttpProgressGlideModule.java @@ -6,6 +6,7 @@ import android.graphics.BitmapFactory; import android.os.Handler; import android.os.Looper; import android.security.KeyChain; +import android.util.Log; import android.util.Size; import androidx.preference.PreferenceManager; @@ -49,6 +50,8 @@ import okio.Source; @GlideModule public class OkHttpProgressGlideModule extends AppGlideModule { + private static final String TAG = "OkHttpProgressGlide"; + @Override public void registerComponents(Context context, Glide glide, Registry registry) { @@ -79,7 +82,7 @@ public class OkHttpProgressGlideModule extends AppGlideModule { // enable mtls in okhttp3 builder builder.sslSocketFactory(sslContext.getSocketFactory()); } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "configuring mTLS", e); } } diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/types/Article.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/types/Article.java index cdffffe2..376aa987 100755 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/types/Article.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/types/Article.java @@ -1,5 +1,7 @@ package org.fox.ttrss.types; +import android.util.Log; + import org.jsoup.Jsoup; import org.jsoup.nodes.Document; import org.jsoup.nodes.Element; @@ -14,6 +16,7 @@ import java.util.regex.Pattern; // TODO: serialize Labels public class Article { + private static final String TAG = "Article"; public static final int TYPE_AMR_FOOTER = -2; public static final int FLAVOR_KIND_ALBUM = 1; @@ -153,7 +156,7 @@ public class Article { flavorStreamUri = null; } } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "collecting media info", e); flavorImage = null; flavorImageUri = null; diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/util/SimpleLoginManager.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/util/SimpleLoginManager.java index 9693a9b6..11e0026d 100644 --- a/org.fox.ttrss/src/main/java/org/fox/ttrss/util/SimpleLoginManager.java +++ b/org.fox.ttrss/src/main/java/org/fox/ttrss/util/SimpleLoginManager.java @@ -47,7 +47,7 @@ public abstract class SimpleLoginManager { } } catch (Exception e) { - e.printStackTrace(); + Log.e(TAG, "authentication request", e); } m_sessionId = null; |
