diff options
| -rw-r--r-- | org.fox.ttrss/src/test/java/org/fox/ttrss/types/ArticleTest.java | 555 |
1 files changed, 555 insertions, 0 deletions
diff --git a/org.fox.ttrss/src/test/java/org/fox/ttrss/types/ArticleTest.java b/org.fox.ttrss/src/test/java/org/fox/ttrss/types/ArticleTest.java new file mode 100644 index 00000000..9ea6a8fb --- /dev/null +++ b/org.fox.ttrss/src/test/java/org/fox/ttrss/types/ArticleTest.java @@ -0,0 +1,555 @@ +package org.fox.ttrss.types; + +import org.jsoup.Jsoup; +import org.jsoup.nodes.Document; +import org.jsoup.nodes.Element; +import org.junit.Test; + +import static org.junit.Assert.*; + +/** + * Tests for Article.java parsing logic. + * Tests the pure-Java methods: fixNullFields, cleanupExcerpt, collectMediaInfo, + * isHostDistinct, getLinkHost, equals, and toString. + */ +public class ArticleTest { + + // ── fixNullFields ──────────────────────────────────────────────────────── + + @Test + public void fixNullFields_setsNullNoteToEmptyString() { + Article article = new Article(); + article.note = null; + article.link = null; + article.tags = null; + article.excerpt = null; + article.content = null; + article.comments_link = null; + + article.fixNullFields(); + + assertEquals("", article.note); + assertEquals("", article.link); + assertNotNull(article.tags); + assertTrue(article.tags.isEmpty()); + assertEquals("", article.excerpt); + assertEquals("", article.content); + assertEquals("", article.comments_link); + } + + @Test + public void fixNullFields_preservesNonNullFields() { + Article article = new Article(); + article.note = "existing note"; + article.link = "https://example.com"; + article.tags = new java.util.ArrayList<>(); + article.tags.add("tag1"); + article.excerpt = "some excerpt"; + article.content = "<p>content</p>"; + article.comments_link = "https://example.com/comments"; + + article.fixNullFields(); + + assertEquals("existing note", article.note); + assertEquals("https://example.com", article.link); + assertEquals(1, article.tags.size()); + assertEquals("some excerpt", article.excerpt); + assertEquals("<p>content</p>", article.content); + assertEquals("https://example.com/comments", article.comments_link); + } + + // ── cleanupExcerpt ─────────────────────────────────────────────────────── + + @Test + public void cleanupExcerpt_replacesHellip() { + Article article = new Article(); + article.excerpt = "This is a long … text"; + article.cleanupExcerpt(); + assertEquals("This is a long … text", article.excerpt); + } + + @Test + public void cleanupExcerpt_stripsCdata() { + Article article = new Article(); + article.excerpt = "Some text <![CDATA[safe content]]]>"; + article.cleanupExcerpt(); + // ]]> is stripped first, then Jsoup parses remaining <![CDATA[safe content] + // leaving a trailing ] from the CDATA bracket + assertEquals("Some text safe content]", article.excerpt); + } + + @Test + public void cleanupExcerpt_stripsHtmlTags() { + Article article = new Article(); + article.excerpt = "<p>Hello <b>world</b></p>"; + article.cleanupExcerpt(); + assertEquals("Hello world", article.excerpt); + } + + @Test + public void cleanupExcerpt_hellipThenHtml() { + Article article = new Article(); + article.excerpt = "A long … <p>story</p>"; + article.cleanupExcerpt(); + assertEquals("A long … story", article.excerpt); + } + + @Test + public void cleanupExcerpt_nullExcerpt_doesNotThrow() { + Article article = new Article(); + article.excerpt = null; + article.cleanupExcerpt(); + assertNull(article.excerpt); + } + + @Test + public void cleanupExcerpt_emptyExcerpt_doesNotThrow() { + Article article = new Article(); + article.excerpt = ""; + article.cleanupExcerpt(); + assertEquals("", article.excerpt); + } + + // ── collectMediaInfo — direct flavor_image ─────────────────────────────── + + @Test + public void collectMediaInfo_usesDirectFlavorImage() { + Article article = new Article(); + article.flavor_image = "https://example.com/image.png"; + article.flavor_stream = "https://example.com/video.mp4"; + article.content = ""; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("https://example.com/image.png", article.flavorImageUri); + assertEquals("https://example.com/video.mp4", article.flavorStreamUri); + assertNotNull(article.flavorImage); + assertEquals("img", article.flavorImage.tagName()); + } + + @Test + public void collectMediaInfo_directFlavorImage_ignoresContent() { + Article article = new Article(); + article.flavor_image = "https://example.com/direct.png"; + article.flavor_stream = ""; + article.content = "<img src='http://other.com/should-not-appear.jpg'>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("https://example.com/direct.png", article.flavorImageUri); + assertNull(article.flavorStreamUri); + } + + @Test + public void collectMediaInfo_emptyFlavorImage_ignoresIt() { + Article article = new Article(); + article.flavor_image = ""; + article.flavor_stream = "https://example.com/stream.mp4"; + article.content = ""; + article.attachments = null; + + article.collectMediaInfo(); + + assertNull(article.flavorImageUri); + assertNull(article.flavorStreamUri); + assertNull(article.flavorImage); + } + + // ── collectMediaInfo — YouTube embed ───────────────────────────────────── + + @Test + public void collectMediaInfo_youtubeEmbed_extractsVideoId() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><iframe src=\"https://www.youtube.com/embed/dQw4w9WgXcQ\"></iframe></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("dQw4w9WgXcQ", article.youtubeVid); + assertEquals("https://img.youtube.com/vi/dQw4w9WgXcQ/hqdefault.jpg", article.flavorImageUri); + assertEquals("https://youtu.be/dQw4w9WgXcQ", article.flavorStreamUri); + assertNotNull(article.flavorImage); + assertEquals("iframe", article.flavorImage.tagName()); + } + + @Test + public void collectMediaInfo_youtubeEmbed_prefersIframeOverImg() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><img src='https://example.com/thumb.jpg'>" + + "<iframe src=\"https://www.youtube.com/embed/abc123\"></iframe></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + // iframe should be preferred over img + assertEquals("abc123", article.youtubeVid); + assertEquals("https://img.youtube.com/vi/abc123/hqdefault.jpg", article.flavorImageUri); + } + + @Test + public void collectMediaInfo_youtubeEmbed_handlesSubpath() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><iframe src=\"https://www.youtube.com/embed/xyz789?start=10\"></iframe></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("xyz789", article.youtubeVid); + } + + // ── collectMediaInfo — video element ───────────────────────────────────── + + @Test + public void collectMediaInfo_videoWithSource_extractsPosterAndStream() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><video poster='https://example.com/poster.jpg'>" + + "<source src='https://example.com/video.mp4'></video></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("https://example.com/poster.jpg", article.flavorImageUri); + assertEquals("https://example.com/video.mp4", article.flavorStreamUri); + assertNotNull(article.flavorImage); + assertEquals("video", article.flavorImage.tagName()); + } + + @Test + public void collectMediaInfo_videoWithoutSource_ignoresIt() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><video></video></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + // No source, so no media info extracted from video + assertNull(article.flavorImageUri); + assertNull(article.flavorStreamUri); + } + + // ── collectMediaInfo — regular image ───────────────────────────────────── + + @Test + public void collectMediaInfo_regularImage_setsUri() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><img src='https://example.com/photo.jpg' alt='photo'></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("https://example.com/photo.jpg", article.flavorImageUri); + assertNull(article.flavorStreamUri); + assertNotNull(article.flavorImage); + assertEquals("img", article.flavorImage.tagName()); + } + + @Test + public void collectMediaInfo_protocolRelativeImage_addsHttps() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><img src='//cdn.example.com/image.png'></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertEquals("https://cdn.example.com/image.png", article.flavorImageUri); + } + + // ── collectMediaInfo — fallback to attachments ─────────────────────────── + + @Test + public void collectMediaInfo_fallbackToImageAttachment() { + Article article = new Article(); + article.flavor_image = null; + article.content = ""; + article.attachments = new java.util.ArrayList<>(); + + Attachment imgAttachment = new Attachment(); + imgAttachment.content_url = "//cdn.example.com/attach.jpg"; + imgAttachment.content_type = "image/jpeg"; + article.attachments.add(imgAttachment); + + article.collectMediaInfo(); + + assertEquals("https://cdn.example.com/attach.jpg", article.flavorImageUri); + assertNotNull(article.flavorImage); + } + + @Test + public void collectMediaInfo_skipsNonImageAttachments() { + Article article = new Article(); + article.flavor_image = null; + article.content = ""; + article.attachments = new java.util.ArrayList<>(); + + Attachment pdf = new Attachment(); + pdf.content_url = "https://example.com/document.pdf"; + pdf.content_type = "application/pdf"; + article.attachments.add(pdf); + + article.collectMediaInfo(); + + assertNull(article.flavorImageUri); + } + + @Test + public void collectMediaInfo_emptyAttachments_doesNotThrow() { + Article article = new Article(); + article.flavor_image = null; + article.content = ""; + article.attachments = new java.util.ArrayList<>(); + + article.collectMediaInfo(); + + assertNull(article.flavorImageUri); + } + + // ── collectMediaInfo — no media at all ─────────────────────────────────── + + @Test + public void collectMediaInfo_noMedia_setsAllToNull() { + Article article = new Article(); + article.flavor_image = null; + article.content = "<html><body><p>just text</p></body></html>"; + article.attachments = null; + + article.collectMediaInfo(); + + assertNull(article.flavorImageUri); + assertNull(article.flavorStreamUri); + assertNull(article.flavorImage); + assertNull(article.youtubeVid); + } + + // ── isHostDistinct ─────────────────────────────────────────────────────── + + @Test + public void isHostDistinct_differentHosts_returnsTrue() { + Article article = new Article(); + article.site_url = "https://example.com"; + article.link = "https://other.com/article"; + + assertTrue(article.isHostDistinct()); + } + + @Test + public void isHostDistinct_sameHost_returnsFalse() { + Article article = new Article(); + article.site_url = "https://example.com"; + article.link = "https://example.com/article"; + + assertFalse(article.isHostDistinct()); + } + + @Test + public void isHostDistinct_wwwNormalized() { + Article article = new Article(); + article.site_url = "https://www.example.com"; + article.link = "https://example.com/article"; + + assertFalse(article.isHostDistinct()); + } + + @Test + public void isHostDistinct_malformedUrl_returnsFalse() { + Article article = new Article(); + article.site_url = "not a url"; + article.link = "https://example.com"; + + assertFalse(article.isHostDistinct()); + } + + @Test + public void isHostDistinct_nullFields_returnsFalse() { + Article article = new Article(); + + assertFalse(article.isHostDistinct()); + } + + // ── getLinkHost ────────────────────────────────────────────────────────── + + @Test + public void getLinkHost_validUrl_returnsHost() { + Article article = new Article(); + article.link = "https://example.com/path/to/article"; + + assertEquals("example.com", article.getLinkHost()); + } + + @Test + public void getLinkHost_subdomain_returnsSubdomain() { + Article article = new Article(); + article.link = "https://blog.example.com/article"; + + assertEquals("blog.example.com", article.getLinkHost()); + } + + @Test + public void getLinkHost_malformedUrl_returnsEmpty() { + Article article = new Article(); + article.link = "not a url"; + + assertEquals("", article.getLinkHost()); + } + + @Test + public void getLinkHost_nullLink_returnsEmpty() { + Article article = new Article(); + article.link = null; + + assertEquals("", article.getLinkHost()); + } + + // ── equals ─────────────────────────────────────────────────────────────── + + @Test + public void equals_sameId_returnsTrue() { + Article a1 = new Article(42); + Article a2 = new Article(42); + + assertTrue(a1.equals(a2)); + } + + @Test + public void equals_differentId_returnsFalse() { + Article a1 = new Article(42); + Article a2 = new Article(43); + + assertFalse(a1.equals(a2)); + } + + @Test + public void equals_null_returnsFalse() { + Article article = new Article(42); + + assertFalse(article.equals(null)); + } + + @Test + public void equals_sameObject_returnsTrue() { + Article article = new Article(42); + + assertTrue(article.equals(article)); + } + + @Test + public void equals_differentClass_returnsFalse() { + Article article = new Article(42); + + assertFalse(article.equals("not an article")); + } + + // ── toString ───────────────────────────────────────────────────────────── + + @Test + public void toString_containsId() { + Article article = new Article(123); + String str = article.toString(); + + assertTrue(str.contains("id:123")); + } + + @Test + public void toString_containsBooleanFields() { + Article article = new Article(1); + article.unread = true; + article.marked = false; + article.published = true; + article.score = 100; + article.selected = true; + + String str = article.toString(); + + assertTrue(str.contains("unread:true")); + assertTrue(str.contains("marked:false")); + assertTrue(str.contains("published:true")); + assertTrue(str.contains("score:100")); + assertTrue(str.contains("selected:true")); + } + + // ── clone ──────────────────────────────────────────────────────────────── + + @Test + public void clone_copiesAllFields() { + Article original = new Article(99); + original.unread = true; + original.marked = false; + original.published = true; + original.score = 42; + original.updated = 1234567890; + original.is_updated = true; + original.title = "Test Title"; + original.link = "https://example.com"; + original.feed_id = 7; + original.tags = new java.util.ArrayList<>(); + original.tags.add("tag1"); + original.attachments = new java.util.ArrayList<>(); + original.content = "<p>content</p>"; + original.excerpt = "excerpt"; + original.labels = new java.util.ArrayList<>(); + original.feed_title = "Test Feed"; + original.comments_count = 5; + original.comments_link = "https://example.com/comments"; + original.always_display_attachments = true; + original.author = "Author Name"; + original.note = "A note"; + original.selected = true; + original.active = true; + original.flavor_image = "https://example.com/thumb.jpg"; + original.flavor_stream = "https://example.com/stream.mp4"; + original.flavor_kind = 2; + original.site_url = "https://example.com"; + + Article clone = new Article(original); + + assertEquals(original.id, clone.id); + assertEquals(original.unread, clone.unread); + assertEquals(original.marked, clone.marked); + assertEquals(original.published, clone.published); + assertEquals(original.score, clone.score); + assertEquals(original.updated, clone.updated); + assertEquals(original.is_updated, clone.is_updated); + assertEquals(original.title, clone.title); + assertEquals(original.link, clone.link); + assertEquals(original.feed_id, clone.feed_id); + assertEquals(original.tags, clone.tags); + assertEquals(original.attachments, clone.attachments); + assertEquals(original.content, clone.content); + assertEquals(original.excerpt, clone.excerpt); + assertEquals(original.labels, clone.labels); + assertEquals(original.feed_title, clone.feed_title); + assertEquals(original.comments_count, clone.comments_count); + assertEquals(original.comments_link, clone.comments_link); + assertEquals(original.always_display_attachments, clone.always_display_attachments); + assertEquals(original.author, clone.author); + assertEquals(original.note, clone.note); + assertEquals(original.selected, clone.selected); + assertEquals(original.active, clone.active); + assertEquals(original.flavor_image, clone.flavor_image); + assertEquals(original.flavor_stream, clone.flavor_stream); + assertEquals(original.flavor_kind, clone.flavor_kind); + assertEquals(original.site_url, clone.site_url); + } + + @Test + public void clone_copiesTransientFields() { + Article original = new Article(1); + original.flavorImageUri = "https://example.com/uri"; + original.flavorStreamUri = "https://example.com/stream"; + original.youtubeVid = "abc123"; + + Article clone = new Article(original); + + assertEquals(original.flavorImageUri, clone.flavorImageUri); + assertEquals(original.flavorStreamUri, clone.flavorStreamUri); + assertEquals(original.youtubeVid, clone.youtubeVid); + } +} |
