1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
package org.fox.ttrss;
import com.google.gson.JsonElement;
import com.google.gson.JsonParser;
import org.junit.Test;
import org.fox.ttrss.ApiCommon.ApiError;
import org.fox.ttrss.ApiResponseParser.ParsedResponse;
import static org.junit.Assert.*;
/**
* Tests for ApiResponseParser — pure logic, no Android dependencies.
*/
public class ApiResponseParserTest {
// ── parse() — success responses ────────────────────────────────────────
@Test
public void parse_successResponse_returnsSuccessTrue() {
String json = "{\"success\":true,\"data\":{\"hello\":\"world\"},\"error\":null}";
ParsedResponse result = ApiResponseParser.parse(json);
assertTrue("Should be successful", result.success);
assertEquals("Error should be SUCCESS", ApiError.SUCCESS, result.error);
}
@Test
public void parse_successResponse_returnsData() {
String json = "{\"success\":true,\"data\":{\"count\":42},\"error\":null}";
ParsedResponse result = ApiResponseParser.parse(json);
assertNotNull("Data should not be null", result.data);
assertEquals("Data should be correct", JsonParser.parseString("{\"count\":42}"), result.data);
}
@Test
public void parse_successResponse_withNullData_returnsNullElement() {
String json = "{\"success\":true,\"data\":null,\"error\":null}";
ParsedResponse result = ApiResponseParser.parse(json);
assertTrue("Should be successful", result.success);
assertNotNull("Data element should exist (null JsonElement)", result.data);
assertTrue("Data should be null JSON", result.data.isJsonNull());
}
@Test
public void parse_successResponse_withEmptyDataObject() {
String json = "{\"success\":true,\"data\":{},\"error\":null}";
ParsedResponse result = ApiResponseParser.parse(json);
assertTrue("Should be successful", result.success);
assertNotNull("Data should not be null", result.data);
assertTrue("Data should be an empty object", result.data.isJsonObject());
}
// ── parse() — error responses ──────────────────────────────────────────
@Test
public void parse_errorResponse_returnsSuccessFalse() {
String json = "{\"success\":false,\"data\":null,\"error\":{\"code\":\"LOGIN_ERROR\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertFalse("Should not be successful", result.success);
assertNotNull("Error should be set", result.error);
}
@Test
public void parse_errorResponse_loginError_mapsToLOGIN_FAILED() {
String json = "{\"success\":false,\"data\":null,\"error\":{\"code\":\"LOGIN_ERROR\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("LOGIN_ERROR should map to LOGIN_FAILED", ApiError.LOGIN_FAILED, result.error);
}
@Test
public void parse_errorResponse_notLoggedIn_mapsToLOGIN_FAILED() {
String json = "{\"success\":false,\"data\":null,\"error\":{\"code\":\"NOT_LOGGED_IN\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("NOT_LOGGED_IN should map to LOGIN_FAILED", ApiError.LOGIN_FAILED, result.error);
}
@Test
public void parse_errorResponse_apiDisabled_mapsToAPI_DISABLED() {
String json = "{\"success\":false,\"data\":null,\"error\":{\"code\":\"API_DISABLED\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("API_DISABLED should map to API_DISABLED", ApiError.API_DISABLED, result.error);
}
@Test
public void parse_errorResponse_incorrectUsage_mapsToAPI_INCORRECT_USAGE() {
String json = "{\"success\":false,\"data\":null,\"error\":{\"code\":\"INCORRECT_USAGE\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("INCORRECT_USAGE should map to API_INCORRECT_USAGE", ApiError.API_INCORRECT_USAGE, result.error);
}
@Test
public void parse_errorResponse_unknownCode_mapsToAPI_UNKNOWN() {
String json = "{\"success\":false,\"data\":null,\"error\":{\"code\":\"SOME_UNKNOWN_CODE\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("Unknown error should map to API_UNKNOWN", ApiError.API_UNKNOWN, result.error);
}
@Test
public void parse_errorResponse_missingCode_mapsToAPI_UNKNOWN() {
String json = "{\"success\":false,\"data\":null,\"error\":{}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("Missing error code should map to API_UNKNOWN", ApiError.API_UNKNOWN, result.error);
}
@Test
public void parse_errorResponse_missingErrorField_mapsToAPI_UNKNOWN() {
String json = "{\"success\":false,\"data\":null}";
ParsedResponse result = ApiResponseParser.parse(json);
assertEquals("Missing error object should map to API_UNKNOWN", ApiError.API_UNKNOWN, result.error);
}
// ── parse() — malformed responses ──────────────────────────────────────
@Test
public void parse_malformedJson_returnsParseError() {
String json = "not valid json at all";
ParsedResponse result = ApiResponseParser.parse(json);
assertFalse("Should not be successful", result.success);
assertEquals("Should be PARSE_ERROR", ApiError.PARSE_ERROR, result.error);
assertNotNull("Error message should be set", result.errorMessage);
assertTrue("Error message should mention parse", result.errorMessage.contains("parse"));
}
@Test
public void parse_missingSuccessField_returnsParseError() {
String json = "{\"data\":{\"hello\":\"world\"}}";
ParsedResponse result = ApiResponseParser.parse(json);
assertFalse("Should not be successful", result.success);
assertEquals("Missing success field should be PARSE_ERROR", ApiError.PARSE_ERROR, result.error);
}
@Test
public void parse_emptyString_returnsParseError() {
ParsedResponse result = ApiResponseParser.parse("");
assertFalse("Should not be successful", result.success);
assertEquals("Empty string should be PARSE_ERROR", ApiError.PARSE_ERROR, result.error);
}
// ── mapApiError() — direct tests ───────────────────────────────────────
@Test
public void mapApiError_loginError_returnsLOGIN_FAILED() {
assertEquals(ApiError.LOGIN_FAILED, ApiResponseParser.mapApiError("LOGIN_ERROR"));
}
@Test
public void mapApiError_notLoggedIn_returnsLOGIN_FAILED() {
assertEquals(ApiError.LOGIN_FAILED, ApiResponseParser.mapApiError("NOT_LOGGED_IN"));
}
@Test
public void mapApiError_apiDisabled_returnsAPI_DISABLED() {
assertEquals(ApiError.API_DISABLED, ApiResponseParser.mapApiError("API_DISABLED"));
}
@Test
public void mapApiError_incorrectUsage_returnsAPI_INCORRECT_USAGE() {
assertEquals(ApiError.API_INCORRECT_USAGE, ApiResponseParser.mapApiError("INCORRECT_USAGE"));
}
@Test
public void mapApiError_unknown_returnsAPI_UNKNOWN() {
assertEquals(ApiError.API_UNKNOWN, ApiResponseParser.mapApiError("SOME_RANDOM_ERROR"));
}
// ── mapHttpStatusError() — direct tests ────────────────────────────────
@Test
public void mapHttpStatusError_400_returnsHTTP_BAD_REQUEST() {
assertEquals(ApiError.HTTP_BAD_REQUEST, ApiResponseParser.mapHttpStatusError(400));
}
@Test
public void mapHttpStatusError_401_returnsHTTP_UNAUTHORIZED() {
assertEquals(ApiError.HTTP_UNAUTHORIZED, ApiResponseParser.mapHttpStatusError(401));
}
@Test
public void mapHttpStatusError_403_returnsHTTP_FORBIDDEN() {
assertEquals(ApiError.HTTP_FORBIDDEN, ApiResponseParser.mapHttpStatusError(403));
}
@Test
public void mapHttpStatusError_404_returnsHTTP_NOT_FOUND() {
assertEquals(ApiError.HTTP_NOT_FOUND, ApiResponseParser.mapHttpStatusError(404));
}
@Test
public void mapHttpStatusError_405_returnsAPI_UNKNOWN_METHOD() {
assertEquals(ApiError.API_UNKNOWN_METHOD, ApiResponseParser.mapHttpStatusError(405));
}
@Test
public void mapHttpStatusError_500_returnsHTTP_SERVER_ERROR() {
assertEquals(ApiError.HTTP_SERVER_ERROR, ApiResponseParser.mapHttpStatusError(500));
}
@Test
public void mapHttpStatusError_501_returnsHTTP_SERVER_ERROR() {
assertEquals(ApiError.HTTP_SERVER_ERROR, ApiResponseParser.mapHttpStatusError(501));
}
@Test
public void mapHttpStatusError_502_returnsHTTP_OTHER_ERROR() {
assertEquals(ApiError.HTTP_OTHER_ERROR, ApiResponseParser.mapHttpStatusError(502));
}
@Test
public void mapHttpStatusError_503_returnsHTTP_OTHER_ERROR() {
assertEquals(ApiError.HTTP_OTHER_ERROR, ApiResponseParser.mapHttpStatusError(503));
}
@Test
public void mapHttpStatusError_200_returnsHTTP_OTHER_ERROR() {
// 200 is a success code, but this method is only called for error responses
assertEquals(ApiError.HTTP_OTHER_ERROR, ApiResponseParser.mapHttpStatusError(200));
}
@Test
public void mapHttpStatusError_999_returnsHTTP_OTHER_ERROR() {
assertEquals(ApiError.HTTP_OTHER_ERROR, ApiResponseParser.mapHttpStatusError(999));
}
}
|